Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow missing health checks w/o flagging as unknown #4

Open
kfiresmith opened this issue Jan 26, 2023 · 0 comments
Open

Allow missing health checks w/o flagging as unknown #4

kfiresmith opened this issue Jan 26, 2023 · 0 comments

Comments

@kfiresmith
Copy link

This is probably beyond me as a Python dabbler, but I think it may be nice to make the check more flexible in how --check-all behaves.

Currently if a statically defined check does not have a matching GitLab health API subject, that check is flagged w/ UNKNOWN status as a monitoring plugin should do when it cannot parse output.

My proposal would be to either by default, or as an option setting (eg --ignore-missing), allow --check-all to skip any checks that don't map to a health API subject.

Perhaps as part of the 'OK' response, it could also return something like 'API doesn't include checks foo, and bar'. And to help flag for future health API changes, it could also return something like 'API includes unmonitored subject foo' when it discovers a health subject that we don't already check for.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant