-
Notifications
You must be signed in to change notification settings - Fork 49
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Export-PSGraph fails when a node is called "graph" #30
Comments
Other node names that cause this:
The first error message is coming from graphviz when it parses the graph output.
I suspect all DOT keywords would cause this failure. |
What do you think about changing this section in Format-Value? # Normal value, no quotes
'^[\w]+$'
{
'"{0}"' -f $value
} I ran through some quick tests and it seems to resolve the issue. |
There are two scenarios that I would need to look at that I may as well document here and get some tests added. The first one is setting note (or edge) attribute defaults.
If that first node gets quotes around it, it becomes a real node instead of defining the attributes for the other nodes. In one case you would get two squares and in the other, you would get one square and two circles. I did notice that custom format scripts are causing issues like this too, so I opened #32 to track it. I'm going to look to see how easy it would be to pull that special case out of the normal format logic. The second is edges to record nodes.
The edge in this example may need some more analysis. I don't have any documentation on record nodes and edges, but I want to maintain that underlying engine compatibility. I am tempted to add a way to turn that off though and that may be a better discussion in another thread. As it stands, it gets in the way of edges to |
Steps to reproduce:
The text was updated successfully, but these errors were encountered: