Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extending the Lightning class (pytorch_adapt/frameworks/lightning/lightning.py) #58

Open
just-eoghan opened this issue Apr 11, 2022 · 1 comment
Labels
enhancement New feature or request

Comments

@just-eoghan
Copy link
Contributor

just-eoghan commented Apr 11, 2022

Suggested Feature

The Lightning class could be extended to include two more functions

  1. test_step
  2. test_epoch_end

Implementation

The test_step and test_epoch end could operate in the same way as the validation_step and epoch_end and return a test_score.

Reasoning

This would allow lightning users to specify a test_dataloader containing a hold-out set in their datamodule. The best saved model on validation data can then be run against the test data using pytorch lightning trainer.test function call.

@KevinMusgrave KevinMusgrave added the enhancement New feature or request label Apr 11, 2022
@KevinMusgrave
Copy link
Owner

Makes sense

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants