[WIP/draft] - serial bridge - mks/bigtreetech uart lcd support #3885
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merge KevinOConnor/klipper
merge KevinOConnor/klipper
|
Interesting. I'm not sure what feedback you are looking for a this time. As high-level feedback, the functionality seems useful to me. The code diffs on this PR are not in a state that I can really review though. (There are several unrelated features, whitespace changes, local build changes etc. that are mixed into the code changes on this PR.) One thing I noticed is that the support as currently defined would require "make menuconfig" selection of the feature. We generally want to avoid that whenever possible. We want to configure Klipper via the printer.cfg file, and not during code compilation. Cheers, |
|
Thanks. I was just hoping someone would finish this project. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I started this project becouse i wanted to connect touch lcd to mcu board, instead of connecting it directly to host. I'm aware of fact that this way of connecting has many disadvantages. However, it's important to me not to modify hardware in any way and not to add any additional usb/uart cables.