Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] Some keys do not register when a text field is first selected (k12 pro) #146

Closed
2 tasks
kuokuo123 opened this issue Jul 22, 2023 · 2 comments
Closed
2 tasks
Labels
bug Something isn't working help wanted Extra attention is needed

Comments

@kuokuo123
Copy link

kuokuo123 commented Jul 22, 2023

Describe the Bug

With the k12 pro's current qmk source code, under bluetooth mode with RGB off, some keys do not register after a text field is selected. This bug occurs when all the below conditions are satified and can be reproduced consistently:

  1. flash a firmware compiled from k12 pro's current qmk source code, modified or unmodified.
  2. unplug the usb wire and use bluetooth connection only
  3. turn off RGB lighting
  4. select a text field in any program on your screen (this is an important step)
  5. press backspace (or other keys mentioned below) and it won't register

Keys that are not registering in this situation include backspace, backslash, enter, right shift and right control. The issue occurs only when using the firmware compiled from k12 pro's qmk source code, which means if you re-flash the stock firmware (v 1.0.0) downloaded from keychron's official website the issue is gone.

Notably, if you plug in the usb wire, or turn on RGB lighting, or do not select a text field beforehand, the keys will register as usual and as expected.

Keyboard Used

keychron/k12_pro/ansi/rgb

Link to product page (if applicable)

https://github.com/Keychron/qmk_firmware/tree/bluetooth_playground/keyboards/keychron/k12_pro

Operating System

linux & windows 10

qmk doctor Output

No response

Is AutoHotKey / Karabiner installed

  • AutoHotKey (Windows)
  • Karabiner (macOS)

Other keyboard-related software installed

None

Additional Context

No response

@kuokuo123 kuokuo123 added bug Something isn't working help wanted Extra attention is needed labels Jul 22, 2023
@lokher
Copy link
Member

lokher commented Jul 23, 2023

can you try changing

for (i = 1; i < (MATRIX_COLS - DIRECT_COL_NUM); i++) {

to

    for (i = DIRECT_COL_NUM; i < (MATRIX_COLS - DIRECT_COL_NUM); i++) {

@kuokuo123
Copy link
Author

Can confirm that changing this line fixes the issue. Now every key registers as expected. Thank you, lokher!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

2 participants