Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When wireless_playground branch will be merged to master? (V1 MAX) #249

Open
RDSlaughter opened this issue Apr 7, 2024 · 4 comments
Open
Labels
help wanted Extra attention is needed question Further information is requested stale

Comments

@RDSlaughter
Copy link

RDSlaughter commented Apr 7, 2024

Issue Description

Hi everyone.
I bought the Keychron v1 Max 2 weeks ago. Various errors are received when building QMK firmware with the current branch. I encountered other errors such as WS2812 pin definitions etc and I fixed them one by one manually by removing the function definitions of some of them (which is not a good way but could not find any resource about it). I was able to build successfully and define custom caps lock and layer rgb indicators. But I could not use the charge indicator in any way. There are things that are out of date and constantly cause errors. And I think the current branch does not match with the ready to use .bin file in the official website for v1 max. I think we need to merge the wireless_playground branch to master.

@RDSlaughter RDSlaughter added help wanted Extra attention is needed question Further information is requested labels Apr 7, 2024
@RDSlaughter RDSlaughter changed the title When wireless_playground branch will be merged to master? When **wireless_playground** branch will be merged to master? Apr 7, 2024
@RDSlaughter RDSlaughter changed the title When **wireless_playground** branch will be merged to master? When wireless_playground branch will be merged to master? Apr 7, 2024
@RDSlaughter RDSlaughter changed the title When wireless_playground branch will be merged to master? When wireless_playground branch will be merged to master? (V1 MAX) Apr 7, 2024
@alex-vg
Copy link

alex-vg commented Apr 10, 2024

see #242

@lokher
Copy link
Member

lokher commented Apr 12, 2024

Did you build with keychron fork and wireless_playground branch?
wireless_playground won't be merged to QMK upstream due to it make much core modification and they don't accept it.

@RDSlaughter
Copy link
Author

Did you build with keychron fork and wireless_playground branch? wireless_playground won't be merged to QMK upstream due to it make much core modification and they don't accept it.

I did, i do not think it is ready to use. At least for v1 max

Copy link

This issue has been automatically marked as stale because it has not had activity in the last 90 days. It will be closed in the next 30 days unless it is tagged properly or other activity occurs.
For maintainers: Please label with bug, in progress, on hold, discussion or to do to prevent the issue from being re-flagged.

@github-actions github-actions bot added the stale label Jul 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Extra attention is needed question Further information is requested stale
Projects
None yet
Development

No branches or pull requests

3 participants