Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove use of user level qmk callbacks #258

Open
nskobelevs opened this issue Apr 29, 2024 · 0 comments
Open

Remove use of user level qmk callbacks #258

nskobelevs opened this issue Apr 29, 2024 · 0 comments
Labels
help wanted Extra attention is needed question Further information is requested

Comments

@nskobelevs
Copy link

Issue Description

Some of the Bluetooth code defines _user specific qmk callbacks, more specifically:

led_matrix_indicators_user, rgb_matrix_indicators_user and dip_switch_update_user in factory_test.c
and led_matrix_indicators_user and rgb_matrix_indicators_user in indicator.c.

I think there's also a non standard handling of dip_switch_update_user in (among others) q3_pro.c. (I would expect the user callback to be called first before modifying the default layer)

Having these as user level means if someone wants to define their own ones, they'd need to go and modify the existing firmware to avoid multiple definitions.

Is there any reason these need to be at the user level and not at the keyboard level? Could these be renamed and called explicitly from the _kb callbacks?

I'm happy to open up a PR if this is okay to change ^

@nskobelevs nskobelevs added help wanted Extra attention is needed question Further information is requested labels Apr 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Extra attention is needed question Further information is requested
Projects
None yet
Development

No branches or pull requests

1 participant