Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix frac-line #1025

Merged
merged 7 commits into from
Dec 26, 2017
Merged

Fix frac-line #1025

merged 7 commits into from
Dec 26, 2017

Conversation

ronkok
Copy link
Collaborator

@ronkok ronkok commented Dec 19, 2017

For frac-line, use an SVG line in an extra tall span.

I still need to think of a way to adust vertical-separator.

For frac-line, use an SVG line in an extra tall span.

I still need to think of a way to adust `vertical-separator`.
@ronkok ronkok changed the title Fix frac-lline Fix frac-line Dec 19, 2017
@ronkok
Copy link
Collaborator Author

ronkok commented Dec 20, 2017

Were the vertical separators disappearing at times? Won't this change to the styling affect the horizontal layout slightly?

Revisiting my response to this comment:

  1. Yes. Issue Dividing lines for array environment sometimes disappear #970
  2. No. It turns out that vertical-separator lines do nothing to the inter-column spacing of an {array}. In the screen shot below, I've drug part of a no-line array over and overlaid it onto an {array}{c|c}. The columns still align perfectly.

In the code for this PR, it was only necessary to adjust the vertical-separator negative left margin. No action is necessary to further fix the horizontal layout.

I believe that we're good to go.

fracline

Copy link
Member

@kevinbarabash kevinbarabash left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kevinbarabash
Copy link
Member

@ronkok you'll have to merge master into your branch and resolve the conflict. I can regenerate those screenshots afterwards.

@kevinbarabash kevinbarabash merged commit c62f814 into KaTeX:master Dec 26, 2017
@kevinbarabash
Copy link
Member

@ronkok thank you for tackling this this issue with the fraction bars disappearing. I'm going to publish a release over the next couple of days. With this change I think it's safe to make it a beta release or release candidate. :)

@ronkok
Copy link
Collaborator Author

ronkok commented Dec 26, 2017

@kevinbarabash You're very welcome. I certainly think that we've now got something better than when we started. I hope it's enough.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants