Alternate approach to capital Greek letters #1285
Conversation
Alternative to KaTeX#1283 and KaTeX#1284 implementing Latin-looking capital Greek letters via symbols instead of macros, which interacts with fonts more correctly.
Codecov Report
@@ Coverage Diff @@
## master #1285 +/- ##
======================================
Coverage 82.5% 82.5%
======================================
Files 60 60
Lines 3893 3893
Branches 651 651
======================================
Hits 3212 3212
Misses 578 578
Partials 103 103
Continue to review full report at Codecov.
|
|
Cool, glad you agree! I wouldn't have thought of this approach without going through all the ensuing discussion, so it's not time wasted. Do you want to review this PR? |
|
@edemaine I don't believe that I can do a final review. I never did accept @kevinbarabash's invitation to collaborate in this repository, out of fear that my poor Git skills would cause some catastrophe. And it looks as though that invitation has now expired. So I remain a contributor. For what it is worth, I've looked at your code and it looks perfect to me. |
Alternative to #1283 and #1284 for solving #1282, implementing Latin-looking capital Greek letters via symbols instead of macros, which interacts with fonts more correctly.
Visual confirmation: (the first 5 letters are Latin, and remain unchanged, while the Β's to the right are capital betas)
This ends up making a mapping from the capital Greek letters to the Latin equivalents in the symbols table. I think it's better than macros because of the correct interaction with fonts. In the future, we could decide to populate the font with Greek capitals for better copy/paste behavior (see #1283 discussion), but the code would be nearly identical, so this is maybe good for now.