Fix underbrace #1304
Merged
Fix underbrace #1304
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes issue #1271
Fix the vertical alignment so that it correctly takes into account the descender of the lower element. Fixes issue 1303.
|
Visual confirmation: |
|
I'll need some help to generate new screenshots for HorizontalBraces. The bug is visible right there in the old screenshot. |
|
That was fast! Screenshots pushed. |
Codecov Report
@@ Coverage Diff @@
## master #1304 +/- ##
======================================
Coverage 83.8% 83.8%
======================================
Files 61 61
Lines 3990 3990
Branches 666 666
======================================
Hits 3344 3344
Misses 547 547
Partials 99 99
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix the vertical alignment of
\underbraceso that it correctly takes into account the descender of the lower element.Fixes #1303.