Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changing a tweak with a value > 100 causes the tweak to return to 100 #60

Closed
anuragt84 opened this issue Aug 7, 2016 · 5 comments
Closed
Labels

Comments

@anuragt84
Copy link

If the initial Int tweak value is set to say 150, and you hit the plus button, the value changes to 101. If you hit the minus button, it changes to 99. Setting a defaultValue while creating the tweak doesn't fix it either.

@bryanjclark
Copy link
Owner

Thanks for the report, @anuragt84!

Do you have some sample code that reproduces the issue? I'm curious to check out a couple of things:

  1. This Tweak init method should prevent you from creating a Tweak where the defaultValue is larger than the maxValue.
  2. There's some code in TweakViewData here that sounds a potential cause of the issue - if you send up some sample code that reproduces the issue I'm happy to check it out!

Cheers, and thanks again for the report!

@bryanjclark
Copy link
Owner

Welp, I'm 100% able to repro. Gonna add a fix here...

@NachoSoto NachoSoto added the bug label Oct 5, 2016
@bryanjclark
Copy link
Owner

Ah, just realized what it is - we're setting the value on UIStepper before we set the minimum/maximum levels. Fix incoming!

@anuragt84
Copy link
Author

Thank you so much. Sorry I couldn't be of much help.

On Oct 5, 2016, at 4:55 PM, Bryan Clark notifications@github.com wrote:

Ah, just realized what it is - we're setting the value on UIStepper before we set the minimum/maximum levels. Fix incoming!


You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or mute the thread.

@bryanjclark
Copy link
Owner

No worries at all! I really appreciate the bug report!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants