Remove decimal value for Int tweak
#83
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sendyhalim
commented
Dec 23, 2016
| @@ -208,7 +208,7 @@ internal final class TweakTableCell: UITableViewCell { | |||
| let doubleValue = viewData.doubleValue! | |||
| self.updateStepper(value: doubleValue, stepperValues: viewData.stepperValues!) | |||
|
|
|||
| textField.text = String(doubleValue) | |||
| textField.text = String(describing: viewData.value) | |||
There was a problem hiding this comment.
I don't know if it's idiomatic or not, if possible I would propose to implement CustomStringConvertible for TweakViewData so that each of the type have their own UI string representation (I will update the PR if you guys ok with that), for now I'll use this approach.
|
Thanks! I'm looking into this now :D |
|
Thanks for tuning up the code inconsistencies, too! :D |
|
Closes #76 |
|
You're welcome ! 🍻 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi this patch includes these:
Inttweak by using theTweakViewDatainternal value representationRelated issue #76