Bug: Out of memory exception when reading old files

[mnowak98]

There seems to be an issue when updating the app, and then reading a save file created in the old version.

Steps to reproduce:
1 Checkout version 3.0.0
2 Add a couple of entries
3 Checkout the newest version => update the app => start the app => app crashes with this error:

java.lang.OutOfMemoryError: OutOfMemoryError thrown while trying to throw OutOfMemoryError; no stack trace available

Re-installing the app fixes this bug but also gets rid of previous entries.

[mnowak98]

I spotted a potential cause:

Sobriety/app/src/main/java/com/katiearose/sobriety/Main.kt

Line 193 in 1129ac0

readCache(cache.inputStream())

you probably didn't intend to recursively call readCache again, but to call readLegacyCache instead?

[KiARC]

Ah darn, I know what caused that too. My autoformatter likes to replace deprecated calls with non-deprecated ones and that's meant to be the call to readCacheLegacy

[mnowak98]

I only spotted it via the little "recursive call" indicator, that Android Studio put next to its line number

[KiARC]

Oh that's what that is ahaha

[KiARC]

Alright, I've fixed this. The fix will be out in the next patch.