Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UI improvements #38

Merged
merged 12 commits into from Oct 20, 2022
Merged

UI improvements #38

merged 12 commits into from Oct 20, 2022

Conversation

unbiaseduser
Copy link
Contributor

@unbiaseduser unbiaseduser commented Oct 18, 2022

I have made some qol improvements on various parts of the ui:

  • Use Material components instead of regular Android components. If you want to implement Material You theme later, you pretty much have to use them. Also, as I explained earlier, you don't have to avoid it and they simply look nicer.
  • Fix toolbar not showing on light mode.
  • Fix a bug where you can pick a future time in today.
  • The date formatting now expands to years, months and weeks. Also, if any time unit is 0, it's hidden. Fixes option for years months days hours minutes #24
  • The Create activity is more optimized for one handed usage. (all elements are positioned lower).

@unbiaseduser
Copy link
Contributor Author

unbiaseduser commented Oct 18, 2022

Hold on a sec. Please wait for me to fix time formatting, it's harder than I thought.

@KiARC
Copy link
Owner

KiARC commented Oct 18, 2022 via email

@unbiaseduser
Copy link
Contributor Author

Everything should be ok now, feel free to ask questions

@KiARC
Copy link
Owner

KiARC commented Oct 20, 2022

I'm merging without checks because they don't want to run, I really hope there's no build issues.

@KiARC KiARC merged commit 785ee5e into KiARC:master Oct 20, 2022
@KiARC
Copy link
Owner

KiARC commented Oct 20, 2022

Crap

@KiARC
Copy link
Owner

KiARC commented Oct 20, 2022

fixed it

@unbiaseduser unbiaseduser deleted the ui-refactor branch October 20, 2022 13:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

option for years months days hours minutes
2 participants