Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

support multi select(API suggestions?) #21

Closed
mohammadsaleh opened this issue Aug 25, 2019 · 6 comments
Closed

support multi select(API suggestions?) #21

mohammadsaleh opened this issue Aug 25, 2019 · 6 comments
Labels
feature Something new is needed help wanted Extra attention is needed

Comments

@mohammadsaleh
Copy link

Hi,
dose it support multi select date by click?!
@the-dr-lazy
Copy link
Contributor

Related to #11

@Kiarash-Z Kiarash-Z added the feature Something new is needed label Aug 25, 2019
@Kiarash-Z
Copy link
Owner

Hi @mohammadsaleh,

This feature will be implemented soon in 1.2.0. I will be working on it 😊

@Kiarash-Z Kiarash-Z changed the title support multi select support multi select(API suggestions?) Aug 25, 2019
@Kiarash-Z
Copy link
Owner

Kiarash-Z commented Aug 25, 2019 •
edited

@thebrodmann @mohammadsaleh I'm thinking of a great API for this feature. For now, we only have 2 main types of date picker:

  • Single-day selection
  • Range day selection
    It's noteworthy that they're distinguished by isDayRange prop. By implementing multi selection, there will be a 3rd type. Any suggestion is welcome! maybe we would have something like a new prop e.g isMultiSelectable (and the prop type change to Array for the selectedDay and selectedDayRange props). Or, we can simply support Array type for these two props. Any other idea? 💡 🤔

@Kiarash-Z Kiarash-Z added the help wanted Extra attention is needed label Aug 25, 2019
@the-dr-lazy the-dr-lazy mentioned this issue Aug 25, 2019
Closed
@the-dr-lazy
Copy link
Contributor

I put my proposal for API change in #22 because it was somewhere between this issue and new issue so I just preferred to open a new issue for that.

@mohammadsaleh
Copy link
Author

Hi @mohammadsaleh,

This feature will be implemented soon in 1.2.0. I will be working on it 😊

Thanks ;)

@Kiarash-Z
Copy link
Owner

Moved to #22

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
feature Something new is needed help wanted Extra attention is needed
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@mohammadsaleh @Kiarash-Z @the-dr-lazy