Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

How to use with keyboard? #54

Closed
J-Kallunki opened this issue Oct 28, 2019 · 5 comments
Closed

How to use with keyboard? #54

J-Kallunki opened this issue Oct 28, 2019 · 5 comments
Labels
bug Something isn't working

Comments

@J-Kallunki
Copy link

Describe the bug
For keyboard / accessibility component shows as input but nothing else. How to select day with keyboard?

Reproduced Version on CodeSandbox
Here it is on CodeSandBox: https://codesandbox.io/s/sad-chatelet-t4s0p

Expected behavior
Input needs to have guidance for screenreader and keyboard can be used to go through calendar and select days.

@J-Kallunki J-Kallunki added the bug Something isn't working label Oct 28, 2019
@Kiarash-Z Kiarash-Z added feature Something new is needed and removed bug Something isn't working labels Oct 28, 2019
@Kiarash-Z
Copy link
Owner

Hi Joonas,

Thanks for the suggestion. Accessibility will definitely improve in the next release. I keep this issue open till the fix 👍

@jeffcrump
Copy link

I'd recommend changing the label back to a bug for this issue, and a critical one at that. Keyboard access is one of the lowest-level accessibility guidelines (WCAG 2.1.1 Keyboard) and is a breaking experience for any user that uses keyboard as a primary navigation tool.

This project is positioned as a drop-in datepicker component, and that makes it even more of a critical bug to fix; anyone who uses this for their own project in the current state will run afoul of the guideline.

@Kiarash-Z Kiarash-Z added bug Something isn't working and removed feature Something new is needed labels Nov 23, 2019
@Kiarash-Z
Copy link
Owner

Thanks, @jeffcrump for the clarification 🙏🏻. I'm working on the new release 😇

@Kiarash-Z Kiarash-Z mentioned this issue Dec 5, 2019
@Kiarash-Z
Copy link
Owner

@J-Kallunki @jeffcrump This is now fixed in v1.1.0 🎉 date picker is now accessible with keyboard and there are huge accessibility improvements.

@jeffcrump
Copy link

Awesome work, @Kiarash-Z !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants