Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

InstallerBuildViewModel.kt and InstallerBuildViewModelImpl.kt are missing from source code #36

Closed
AgentHV opened this issue Mar 3, 2022 · 2 comments

Comments

@AgentHV
Copy link

AgentHV commented Mar 3, 2022

The classes com.kieronquinn.app.ambientmusicmod.app.ui.installer.build.InstallerBuildViewModel and com.kieronquinn.app.ambientmusicmod.app.ui.installer.build.InstallerBuildViewModelImpl are mentioned in AmbientApplication.kt but the whole ui/installer/build package is missing with them in it. Therefore the app wont build or if outcommenting those the whole Magisk module builder tab is missing.

@AgentHV
Copy link
Author

AgentHV commented Mar 10, 2022

Bump

I hate being that guy but until this is resolved fixing any bugs is completely dependent on your personal device choice as no one else will be able to build the app. So this whole open source project is indirectly dependent on OnePlus delivering Android 12 for the 7 Pro now...

@KieronQuinn
Copy link
Owner

Done. It was a .gitignore issue, not intentional.

As for the OnePlus thing, I don't have another non-Pixel device that is running 12. It's hardly my "personal device choice", I don't intentionally choose devices that are slow to be updated - in fact, the opposite is why I got the 7TP in the first place, but OnePlus has stopped being fast at updating devices, so there's nothing I can do.

Debugging Xposed modules to fix things like this via remote logs is incredibly slow and painful. I already know that Android 12 contains significant changes to how sound trigger works (including native support for music recognition apps, which I do not intend to support, as the original app does not), so I anticipate it'd be almost impossible to update without having access to a device to work on.

It took nearly 3 and a half years of work to get this module working in the first place, I'm sure people can wait a bit longer for it to support 12.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants