New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Request: make it clearer what this library is doing, using screenshots on the main page #3
Comments
It could maybe be a little bit better, but does "App-level wallpaper color palette generation" not mean "it takes the colors out of wallpapers and generates a palette"? |
@KieronQuinn But then it means it just generate colors out of wallpapers, which is something we already have (and even for very old Android versions, as part of Android-x) : and this library doesn't do just that. It actually allows to use them inside the app, like the Monet effect on Android 12, no? |
Well yes, but Palette is not Monet. Palette extracts colors from images, but it doesn't mutate them and generate whole sets of swatches like Monet does. The whole point of this project is to backport Monet, and it kind of expects that you know what Monet is. Palette is actually used to extract the primary color(s) to feed into MonetCompat on Android 8.0 and below. As for using it on the Views, it's up to you how/if you do that. Applying to views is not automatic, as is described in the Usage page, hence "Next, to apply Monet colors to views, check out the Usage page." |
@KieronQuinn Still I think the current one is unclear. Anyway please update the main page. |
Done. You don't have to mention someone in every comment by the way, if they want to have notifications for issues they will get pinged. |
Thank you. |
Took me some time to understand what it's all about, because it's written in an unclear way:
"MonetCompat is an app-level implementation of kdrag0n's custom Monet implementation, used in his android12-extensions module"
It should say that it takes the colors out of wallpapers and be able to apply them inside the app on various Views, no?
The text was updated successfully, but these errors were encountered: