Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

How to position toolbar to bottom in bubble theme? (Not an Issue) #345

Closed
madhavan-sundararaj opened this issue Feb 26, 2019 · 4 comments
Closed

Comments

@madhavan-sundararaj
Copy link

madhavan-sundararaj commented Feb 26, 2019

I saw your ngx-quill live demo and in that, bubble theme has toolbar below the highlighted word but when I incorporate bubble theme, I get toolbar in top of highlighted word, this causes an issue when using on mobile phone where inbuilt mobile toolbar appears in top of word. I have added screenshot of how it's currently looking in my website.
screen shot 2019-02-26 at 4 46 03 pm
I cloned your live demo repo and it works fine in that, i tried using all css stylesheet from your repo (including "/node_modules/quill/dist/quill.bubble.css") too but still I am getting it at top. Is there anything I am missing here?

My html code:
<quill-editor theme="bubble"> </quill-editor>

@madhavan-sundararaj madhavan-sundararaj changed the title How to position toolbar down in bubble theme? (Not an Issue) How to position toolbar to bottom in bubble theme? (Not an Issue) Feb 26, 2019
@KillerCodeMonkey
Copy link
Owner

ehhm i think this is a quilljs related issue. :)
quilljs/quill#1843

so maybe reopen the issue there?

But i have one idea:
ngx-quill and quilljs has a bounds config property. Try to pass a selector or parent node of your editor.

Default ist the document.body, if you pass the string self the editor element is used :)
https://quilljs.com/docs/configuration/#bounds
https://github.com/KillerCodeMonkey/ngx-quill#config --> check for bounds

And that is strange -> in my live demo is a bubble theme example, too. And there it is at the bottom
https://killercodemonkey.github.io/ngx-quill-example/

Just try my "hints" and if this does not work please ask directly in the quilljs repo

@madhavan-sundararaj
Copy link
Author

I figured out one more thing, if you remove all the components and keep only app-bubble-editor in your live demo, the toolbar is shown on top, I thought this is something to do with editor height and tried increasing my editor height but still it was appearing on top and thank you for the reply, I will open an issue in quill js.

@KillerCodeMonkey
Copy link
Owner

thanks just let me know, if you found a solution or link your issue there.

@madhavan-sundararaj
Copy link
Author

Yes, your solution worked bounds='self'. Thank you for your help and sorry for the late reply.

Cheers

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants