Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed %tokens command #896

Merged
merged 2 commits into from
Jan 18, 2024

Conversation

CyanideByte
Copy link
Contributor

@CyanideByte CyanideByte commented Jan 10, 2024

Describe the changes you have made:

Just updated variables to the new names to fix a crash

Reference any relevant issues (e.g. "Fixes #000"):

Pre-Submission Checklist (optional but appreciated):

  • I have included relevant documentation updates (stored in /docs)
  • I have read docs/CONTRIBUTING.md
  • I have read docs/ROADMAP.md

OS Tests (optional but appreciated):

  • Tested on Windows
  • Tested on MacOS
  • Tested on Linux

@Notnaton
Copy link
Collaborator

Nice catch!
We should add all commands to tests @KillianLucas?

@KillianLucas
Copy link
Collaborator

Looks great! Many thanks @CyanideByte. I would have never caught this, and it totally breaks %tokens without your patch.

And I agree @Notnaton— though I'm not sure how to test %magic commands since they only exist for the terminal interface... I think we'll need to use a subprocess to run interpreter and test them (but they'll be hard to verify if they've passed...)

@KillianLucas KillianLucas merged commit abe07fb into OpenInterpreter:main Jan 18, 2024
0 of 2 checks passed
@CyanideByte CyanideByte deleted the tokens_command_fix branch January 20, 2024 20:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants