NOISSUE remove extant error log, blacklist .log files in .gitignore, … #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
log gone good. multiple os is needed to make sure that the artifacts work for both windows and linux |
|
|
when using java on native code, os dependency is needed. also idk why only one is uploaded, its stolen from the fabric example mod. also the compiling is more for making sure someone doesnt break the jars needed for multiple os |
ah, alright, makes sense. I'll modify the PR accordingly. |
…and have both OS' upload artifacts
ImperatorStorm
force-pushed
the
fix-CI-and-remove-error-log
branch
from
3944fd0
to
7d207d6
Compare
|
alright lgtm @hYdos you review |
hYdos
approved these changes
Jul 1, 2021
CodingRays
added a commit
that referenced
this pull request
Jul 10, 2022
Some patches to device and instance management
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…and have both OS' upload artifacts.
PRIOR TO EDIT:
…and have CI only compile on Ubuntu 20.04, as there's no reason to compile on two OS' when it comes to Java, especially if you're only uploading artifacts from one of them.