Fix vertex strides issues and a device memory leak #31
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The vertex stride issue has now been fixed without needing to rebind the buffer. |
CodingRays
changed the title
|
Also added a small patch that frees the vertex buffers when they get overwritten |
|
looks good, gonna merge to big_nuts and merge big_nuts to master |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So i fixed the vertex strides issues by rebinding the main buffer before each draw call with a byte offset. It is an ugly hack but honestly im not sure if it is possible to do this cleanly without some refractors.
Also the RenderSystemMixin required the
remap = falseotherwise it would not build for me.