Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use pydantic for all serialization #27

Open
Kilo59 opened this issue May 10, 2020 · 0 comments
Open

Use pydantic for all serialization #27

Kilo59 opened this issue May 10, 2020 · 0 comments
Assignees
Labels
domain_model Issue related to modeling of the COVID data

Comments

@Kilo59
Copy link
Owner

Kilo59 commented May 10, 2020

There are currently two layers of modeling for the location data.

Ideally, the pydantic response models should be the only domain models required for the location data.
However, to avoid a large re-design all at once it might be easier to improve and simplify the intermediate non-pydantic domain models.

https://github.com/Kilo59/coronavirus-tracker-api/blob/master/app/location/__init__.py#L8
https://github.com/Kilo59/coronavirus-tracker-api/blob/master/app/location/csbs.py#L5
https://github.com/Kilo59/coronavirus-tracker-api/blob/master/app/location/nyt.py#L5

At a minimum, these domain models should be updated so that they can easily be "deserialized" from their "serialized" versions. Which as of now they cannot 😦 .

@Kilo59 Kilo59 self-assigned this May 10, 2020
@Kilo59 Kilo59 added the domain_model Issue related to modeling of the COVID data label May 10, 2020
@Kilo59 Kilo59 linked a pull request Aug 10, 2020 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
domain_model Issue related to modeling of the COVID data
Projects
None yet
Development

No branches or pull requests

1 participant