-
Notifications
You must be signed in to change notification settings - Fork 419
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Nothing shows in Layer XXX_RAW
when calling pretty_print
with include_raw=True
#587
Comments
sudo tshark -l -n -T ek -x -P -V -i eth0 -c 1 Using ek mode, tshark return a JSON object which the type of However, in the source code the author parses it as dict. pyshark/src/pyshark/packet/layers/ek_layer.py Lines 42 to 44 in 60f0821
The function pyshark/src/pyshark/packet/layers/ek_layer.py Lines 109 to 126 in 60f0821
pyshark/src/pyshark/packet/layers/ek_layer.py Lines 63 to 76 in 60f0821
The raw layers belong to str type, which have no keys. It seems that another issue #586 is also caused by this problem. |
This is still a problem today. This function that's in packet doesn't work either. The assert checks that FRAME_RAW is in the packet, which it is, but self.frame_raw.value isn't valid.
I've tried updating the code to put frame_raw into the frame dictionary so that the EkLayer can access it that way, but that didn't work either. There must be some lookup table indicating what the valid fields are. |
Describe the bug
No matter
use_ek=True, include_raw=True
oruse_json=True, include_raw=True
, nothing shows inLayer XXX_RAW
when callingpretty_print
.To Reproduce
Replace
use_ek
withuse_json
, and as the same nothing shows inxxx_raw
layer.Expected behavior
Show the raw hex data in the specific
xxx_raw
fields.Versions (please complete the following information):
The bug also occurs on Linux (Ubuntu 20.04) with pyshark v0.5.3 and TShark (Wireshark) 3.2.3 (Git v3.2.3 packaged as 3.2.3-1).
The text was updated successfully, but these errors were encountered: