Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix_radicals() not being called properly #1

Closed
joegilkes opened this issue Nov 4, 2023 · 1 comment
Closed

fix_radicals() not being called properly #1

joegilkes opened this issue Nov 4, 2023 · 1 comment

Comments

@joegilkes
Copy link
Collaborator

When comparing KPM output reactions to Kinetica input reactions, there are some discrepancies with radical reactions. For example:

["[CH]=C", "[CH]=C"] -> ["[CH2]", "[CH2]C=[CH]"] (Kinetica input) | SubString{String}["[CH]=C", "[CH]=C"] -> SubString{String}["[CH2]", "[CH][CH][CH2]"] (KPM output)
["[CH2]", "[CH2]C=[CH]"] -> ["[CH]=C", "[CH]=C"] (Kinetica input) | SubString{String}["[CH2]", "[CH][CH][CH2]"] -> SubString{String}["[CH]=C", "[CH]=C"] (KPM output)

This warrants some investigation, but could be sidestepped entirely by not passing XYZ geometries into KPM and instead using the Kinetica-prepared SMILES

@joegilkes
Copy link
Collaborator Author

Fixed by b35a298. Still unsure why this was happening, but directly using the SMILES from RxData instead of recomputing from geometries ensures consistency, while also massively speeding up predictions by avoiding redundant work and file IO.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant