Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ADD] Additional Halfling names #6

Closed
KingFruit85 opened this issue Oct 8, 2019 · 2 comments · Fixed by #45
Closed

[ADD] Additional Halfling names #6

KingFruit85 opened this issue Oct 8, 2019 · 2 comments · Fixed by #45

Comments

@KingFruit85
Copy link
Owner

KingFruit85 commented Oct 8, 2019

Add additional first names and surnames to names.js

names can be generated from several online fantasy generators

I know it's simple but good for a total beginner learning forking, cloning & pull requests.

@KingFruit85 KingFruit85 added the good first issue Good for newcomers label Oct 8, 2019
@KingFruit85 KingFruit85 changed the title [ADD] Halfling language [ADD] Halfling names Oct 8, 2019
@KingFruit85 KingFruit85 changed the title [ADD] Halfling names [ADD] Additional Halfling names Oct 9, 2019
@cindyledev
Copy link
Contributor

Hello, can I contribute to this?

@cindyledev cindyledev mentioned this issue Oct 15, 2019
3 tasks
@HedgehogHolly HedgehogHolly removed their assignment Oct 15, 2019
@KingFruit85
Copy link
Owner Author

@cindyledev Of course, see pull request for feddback 😁

Dungeons & Dragons Random Character Creator automation moved this from In progress to Done Oct 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Development

Successfully merging a pull request may close this issue.

3 participants