Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

t.animate is not a function. #562

Closed
yuchiXiong opened this issue Sep 22, 2023 · 4 comments
Closed

t.animate is not a function. #562

yuchiXiong opened this issue Sep 22, 2023 · 4 comments
Labels

Comments

@yuchiXiong
Copy link

Describe the bug
Now OverlayScrollbars seems to use the HTMLElement.prototype.animate API.

However, the minimum version requirement of this API on IOS devices is IOS13.4, when I used OverlayScrollbars on IOS13.3.1 device, OverlayScrollbars tell me "t.animate is not a function". then blocking the subsequent logic of the page.

I found a github repo that provides a working solution, and now I want to know if OverlayScrollbars can provide a corresponding solution (……or make this issue more effective to help other people who encounter similar problems? 😂😂😂)

To Reproduce
Steps to reproduce the behavior:

  1. find a IOS devices and need IOS version less than 13.4
  2. install OverlayScrollbars and init it
  3. check the console
  4. now you can see a "t.animate is not a function" error.

Expected behavior
Is it possible for OverlayScrollbars to be compatible with it?
(Or I hope this issue can effectively help other developers who may face this problem solve this problem😂)

@KingSora
Copy link
Owner

KingSora commented Sep 22, 2023

Good day @yuchiXiong

OverlayScrollbars should only use element.animate when the browser also supports the ScrollTimelineApi. I just forgot to guard the call to element.animate in this case.

I'll fix this as fast as possible an release a new patch version

@KingSora
Copy link
Owner

@yuchiXiong I've published v2.3.2 which should fix this bug. Please try it out and report back to me :)

@yuchiXiong
Copy link
Author

@yuchiXiong I've published v2.3.2 which should fix this bug. Please try it out and report back to me :)

It's working great now, that's cool! 🎉🎉🎉

@ellockie
Copy link

This was breaking a bunch of unit tests, thank you for fixing it, @KingSora !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants