Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error caused when routing #627

Closed
LynithDev opened this issue Apr 12, 2024 · 5 comments
Closed

Error caused when routing #627

LynithDev opened this issue Apr 12, 2024 · 5 comments
Labels

Comments

@LynithDev
Copy link

Describe the bug
Whenever I switch pages using solid-router, I start getting errors with OverlayScrollbars,

[Error] Unhandled Promise Rejection: TypeError: null is not an object (evaluating 'S.top')
	(anonymous function) (overlayscrollbars.mjs:2367)

The source file and location it occurs at is in structureSetup.elements.ts:276

To Reproduce
Steps to reproduce the behavior:

  1. Switch to a different page
  2. Switch to the previous page
  3. Scrollbar doesn't show up and throws an error

Expected behavior
No errors get thrown and the scrollbar displays and handles user interaction properly.

Environment

  • Used Operating System(s): Fedora Linux 39 x86_64
  • Used Browser(s) (with version): WebKitGTK (webkit2gtk4.1-devel.x86_64 2.44.0-2.fc39) in a Tauri App
@KingSora
Copy link
Owner

KingSora commented Apr 12, 2024

Good day @LynithDev :)

I've found the issue - document.defaultView can be null and I'm not accounting for this. I'm not sure when this happens and this is actually the first environment where I can observe this.

I'll publish a fix soon - sorry for the inconvenience

@LynithDev
Copy link
Author

No worries, the library is fairly simple to use and mostly just works. I appreciate the work 👍

@KingSora
Copy link
Owner

@LynithDev I've published OverlayScrollbars v2.7.2 which should fix your issue :)

@LynithDev
Copy link
Author

I'll try it later today, thanks 👍

@LynithDev
Copy link
Author

Can confirm that it has fixed the issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants