Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Specify MoveIt Planners to use #157

Merged
merged 5 commits into from Aug 9, 2023
Merged

Specify MoveIt Planners to use #157

merged 5 commits into from Aug 9, 2023

Conversation

abake48
Copy link
Contributor

@abake48 abake48 commented Jul 26, 2023

Define MoveIt planners to use. This way, we can avoid trying to use Stomp in a version of ROS where it isn't available/released.

@abake48 abake48 enabled auto-merge (squash) July 26, 2023 20:03
@moriarty
Copy link
Collaborator

That's a weird failure

  ERROR: the following rosdeps failed to install
    apt: command [apt-get install -y -qq ros-humble-rviz2] failed
  '( source /opt/ros/humble/setup.bash && rosdep install -q --from-paths /home/runner/work/ros2_kortex/ros2_kortex/.work/upstream_ws/src --ignore-src -y | grep -E '(executing command)|(Setting up)' ; )' returned with 1
'install_upstream_dependencies' returned with code '1' after 1 min 41 sec

@abake48
Copy link
Contributor Author

abake48 commented Aug 2, 2023

This is such an odd error... is the apt package just ros-rolling-rviz, no 2?

@moriarty
Copy link
Collaborator

moriarty commented Aug 7, 2023

@abake48 this PR says no lines added no lines removed after you merged main into this PR, did something get lost or did something already get in via another PR?

@abake48
Copy link
Contributor Author

abake48 commented Aug 7, 2023

Something must have gotten lost when the launch file refactor PR got merged. I'll update this PR to add chomp and pilz planner

@moriarty moriarty self-requested a review August 9, 2023 14:11
Copy link
Collaborator

@moriarty moriarty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@abake48 abake48 merged commit b71d636 into main Aug 9, 2023
10 checks passed
@abake48 abake48 deleted the define-planners branch August 9, 2023 14:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants