Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

馃毀Improve project README #38

Closed
9 tasks done
CalvinWilkinson opened this issue Aug 23, 2022 · 2 comments 路 Fixed by #40
Closed
9 tasks done

馃毀Improve project README #38

CalvinWilkinson opened this issue Aug 23, 2022 · 2 comments 路 Fixed by #40
Assignees
Labels
馃摑documentation/product Product documentation external to source code. Doc website low priority Low Priority preview Done while in preview

Comments

@CalvinWilkinson
Copy link
Member

CalvinWilkinson commented Aug 23, 2022

Complete Items Below

  • I have updated the title without removing the 馃毀 emoji.

Description

Improve the project's readme so the text in the What's the point? 馃し馃徏 section is laid out better. Currently the way that the text is wrapping is making the layout all WONKY and difficult to read. The assumption is that the markdown is setup to force wrap the sentences instead of auto-wrapping the text.

Either way, it does not look great.

馃挕Use VSCode to view the rendered markdown with the approximately the same width as in the browser in the marketplace, and use this as a guide to layout the text.

Currently On Marketplace:
image

Convert the action input example values to inline code blocks to emphasize what it should look like.
The text to convert are in the purple rectangles in the image below:
image

Acceptance Criteria

  • Section in README changed to lay out text in a better way
  • Input value examples converted into markdown inline code blocks
    • This is done by simply adding a single backtick to each end of the text you want to convert to an inline code block.

ToDo Items

  • Change type labels added to this issue. Refer to the Change Type Labels section below.
  • Priority label added to this issue. Refer to the Priority Type Labels section below.
  • Issue linked to the correct project (if required).
  • Issue linked to the correct milestone (if required).
  • Draft pull request created and linked to this issue (only required with code changes).

Issue Dependencies

No response

Related Work

No response

Additional Information:

Change Type Labels

Change Type Label
Bug Fixes 馃悰bug Something isn't working
Breaking Changes 馃Жbreaking changes Feature/changes contains breaking changes
New Feature 鉁╪ew feature New feature that does not exist
Workflow Changes https://github.com/KinsonDigital/BranchValidator/labels/workflow
Code Doc Changes 馃搼documentation/code Code documentation changes in source code. XML code docs/comments
Product Doc Changes 馃摑documentation/product Product documentation external to source code. Doc website

Priority Type Labels

Priority Type Label
Low Priority low priority Low Priority
Medium Priority medium priority Medium Priority
High Priority high priority High Priority

Code of Conduct

  • I agree to follow this project's Code of Conduct.
@CalvinWilkinson CalvinWilkinson added the low priority Low Priority label Aug 23, 2022
@CalvinWilkinson CalvinWilkinson added this to the v1.0.0 milestone Aug 23, 2022
@CalvinWilkinson CalvinWilkinson changed the title 馃毀Improve section in README 馃毀Improve project README Aug 23, 2022
@CalvinWilkinson
Copy link
Member Author

@kselena In the picture above with the purple rectangles, the words Example 1:, Example 2:, etc., do you think those should be italic?

Don't be afraid to come up with some ideas to improve the readability and layout of this document. You can play around with different things in VSCode as well.

@CalvinWilkinson CalvinWilkinson removed this from the v1.0.0 milestone Aug 23, 2022
@kselena kselena linked a pull request Aug 24, 2022 that will close this issue
10 tasks
@kselena kselena added the preview Done while in preview label Aug 24, 2022
@kselena kselena added this to the v1.0.0-preview.3 milestone Aug 24, 2022
@KinsonDigitalAdmin KinsonDigitalAdmin added the 馃摑documentation/product Product documentation external to source code. Doc website label Aug 25, 2022
@KinsonDigitalAdmin
Copy link
Collaborator

@kselena Just a quick heads up. Anytime you change anything that has to do with the product documentation, we need a 馃摑documentation/product Product documentation external to source code. Doc website label.

I went ahead and added one for both the PR and the issue.

It is a little tricky. If I am adding a new method that has code docs, those code docs end up in the API documentation website., but I will not put the 馃摑documentation/product Product documentation external to source code. Doc website on that issue. The reason is that the 馃摑documentation/product Product documentation external to source code. Doc website is meant only for documentation changes without changes to the original code base.

For example, if I had an issue to ONLY changing the code docs, then that would take the 馃摑documentation/product Product documentation external to source code. Doc website label.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
馃摑documentation/product Product documentation external to source code. Doc website low priority Low Priority preview Done while in preview
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants