Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

callbacks never called #17

Open
pteasima opened this issue Jun 21, 2018 · 1 comment
Open

callbacks never called #17

pteasima opened this issue Jun 21, 2018 · 1 comment
Assignees

Comments

@pteasima
Copy link

steps to reproduce: make a failed URL request using etherKit, e.g. give it a url that isnt running a node

expected: callback is called with the Result containing .failure(theNetworkingError)

actual: callback is never called https://github.com/Vaultio/EtherKit/blob/master/EtherKit/RequestProtocols/URLRequestManager.swift line 35 just returns.

notes: I found another place where this can theoretically happen https://github.com/Vaultio/EtherKit/blob/master/EtherKit/RequestProtocols/RequestManager.swift line 45 , there may be others

@pr0zac
Copy link
Contributor

pr0zac commented Jun 21, 2018

Acknowledged! Thanks @pteasima!

@SirensOfTitan SirensOfTitan self-assigned this Jun 21, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants