Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Validate provided collection JSON schema #75

Closed
n1k0 opened this issue May 20, 2016 · 8 comments
Closed

Validate provided collection JSON schema #75

n1k0 opened this issue May 20, 2016 · 8 comments

Comments

@n1k0
Copy link
Contributor

n1k0 commented May 20, 2016

I've just spent a few unecessary minutes trying to figure out a weird error I had in the admin because I misspelled properties in my schema, while it was accepted just fine when submitted.

We should validate the entered JSON schema, eg. using https://github.com/mafintosh/is-my-json-valid.

@n1k0
Copy link
Contributor Author

n1k0 commented May 20, 2016

We should validate the entered JSON schema, eg. using https://github.com/mafintosh/is-my-json-valid.

WELL, probably not with this one.

@Natim
Copy link
Member

Natim commented May 20, 2016

We already have a JSON schema validator actually.

@Natim
Copy link
Member

Natim commented May 20, 2016

@n1k0
Copy link
Contributor Author

n1k0 commented May 20, 2016

Well, could it be tweaked a little then? Entering this doesn't make it fail :/

{
  "type": "object",
  "porperties": {
    "content": {
      "type": "string"
    },
    "title": {
      "type": "string"
    }
  }
}

Note porperties.

@n1k0
Copy link
Contributor Author

n1k0 commented May 20, 2016

For example if there's an option to disallow unknown JSON schema property names in the schema itself, that would be nice.

@n1k0 n1k0 added the ux label May 25, 2016
@leplatrem
Copy link
Contributor

Duplicate of #253 ?

@n1k0
Copy link
Contributor Author

n1k0 commented Jan 20, 2017

Not really, here the purpose would be to check that the entered json schema actually matches the json schema spec.

@alexcottner
Copy link
Contributor

Closed with PR 3043.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants