This repository has been archived by the owner on Feb 8, 2022. It is now read-only.
Reworked config check scripts to work with pytest #9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
karlht
approved these changes
Feb 13, 2017
| oauth_server_url = https://oauth.accounts.firefox.com/v1 | ||
| fxa_user_email = | ||
| fxa_user_password = | ||
| qa_collection = 3e0f013d2362aa4fa7b0db2fefb40011b9545d78dcca7aabc0d32f0b42f1733d |
There was a problem hiding this comment.
Do we want the qa_collection uuid to be the same between stage and prod, or do we care?
There was a problem hiding this comment.
We don't care because we just need something unique that Firefox will not attempt to read and use
| @@ -1,6 +1,18 @@ | |||
| [stage] | |||
| server = https://kinto.stage.mozaws.net/v1 | |||
| writer_server = https://kinto-writer.stage.mozaws.net/v1 | |||
There was a problem hiding this comment.
Does prod have a writer_server?
There was a problem hiding this comment.
prod does have one but QA does not have access to it --- the staging value is used for our stage-deployment testing
|
Chris, please feel free to merge this whenever you like. r+ |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
r? @karlht