Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Paginated delete missing last page token #1170

Closed
gabisurita opened this issue Mar 26, 2017 · 3 comments · Fixed by #1630
Closed

Paginated delete missing last page token #1170

gabisurita opened this issue Mar 26, 2017 · 3 comments · Fixed by #1630
Labels

Comments

@gabisurita
Copy link
Member

# create three records
> http post localhost:8888/v1/buckets -a a:a
> http post localhost:8888/v1/buckets -a a:a
> http post localhost:8888/v1/buckets -a a:a
(...)

gsurita-30820:~ gsurita$ http delete localhost:8888/v1/buckets?_limit=1 -a a:a
HTTP/1.1 200 OK
Access-Control-Expose-Headers: Backoff, Retry-After, Content-Length, Alert
Content-Length: 73
Content-Type: application/json
Date: Sun, 26 Mar 2017 12:51:21 GMT
Etag: "1490532681567"
Last-Modified: Sun, 26 Mar 2017 12:51:21 GMT
Next-Page: http://localhost:8888/v1/buckets?_limit=1&_token=eyJsYXN0X3JlY29yZCI6eyJsYXN0X21vZGlmaWVkIjoxNDkwNTMyNjgxNTY3fSwib2Zmc2V0IjoxfQ%3D%3D
Server: waitress
Total-Records: 3
X-Content-Type-Options: nosniff

{
    "data": [
        {
            "deleted": true,
            "id": "29Bbx5Bu",
            "last_modified": 1490532681567
        }
    ]
}

gsurita-30820:~ gsurita$ http delete "http://localhost:8888/v1/buckets?_limit=1&_token=eyJsYXN0X3JlY29yZCI6eyJsYXN0X21vZGlmaWVkIjoxNDkwNTMyNjgxNTY3fSwib2Zmc2V0IjoxfQ%3D%3D" -a a:a
HTTP/1.1 200 OK
Access-Control-Expose-Headers: Backoff, Retry-After, Content-Length, Alert
Content-Length: 73
Content-Type: application/json
Date: Sun, 26 Mar 2017 12:52:05 GMT
Etag: "1490532725067"
Last-Modified: Sun, 26 Mar 2017 12:52:05 GMT
Server: waitress
Total-Records: 2
X-Content-Type-Options: nosniff

{
    "data": [
        {
            "deleted": true,
            "id": "IrkBjOFr",
            "last_modified": 1490532725067
        }
    ]
}
@gabisurita gabisurita added the bug label Mar 26, 2017
@Natim
Copy link
Member

Natim commented Mar 26, 2017

The Total-Records count change is concerning.

@gabisurita
Copy link
Member Author

gabisurita commented Mar 27, 2017

I don't think total records changing is an issue, as long as the pagination is right.

@Natim
Copy link
Member

Natim commented Mar 28, 2017

In that case that is why the pagination is not right.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants