Move up to fstrings #1886
Move up to fstrings #1886
Conversation
|
There may be some issues still. My local builds still fail on lint and functional ENV's. Perhaps it is correct for the functional build to fail as it runs on 3.5? There are also some lines of code that I'm unsure of on how to convert to fstrings at the moment. I'll look into those over the next few days. Code review/advice is very much appreciated |
kinto/core/authentication.py
Outdated
| @@ -34,6 +34,7 @@ def unauthenticated_userid(self, request): | |||
| return | |||
|
|
|||
| hmac_secret = settings["userid_hmac_secret"] | |||
| # Unsure how to use fstring with *args | |||
There was a problem hiding this comment.
I would say that f"{credentials[0]}:{credentials[1]" is fine. Or leave the format() call
kinto/core/events.py
Outdated
| @@ -29,6 +29,7 @@ def __init__(self, payload, request): | |||
| self.request = request | |||
|
|
|||
| def __repr__(self): | |||
| # Not sure what proper conversion to fstring is | |||
There was a problem hiding this comment.
This is probably better to leave it with format()
There was a problem hiding this comment.
We could do this, I think it should work
| # Not sure what proper conversion to fstring is | |
| # def __repr__(self): | |
| return f"<{self.__class__.__name__} action={self.payload['action']} uri={self.payload['uri']}>" |
|
It looks to me! Thanks for taking the time to do this!
This PR will drop support of Python 3.5. It looks like you should run black to format your changes (see TravisCI job py36) |
|
It's my pleasure! About the TravisCI config, we should update the python version but also tell Travis that we expect 3.5 to fail, correct? |
No we should remove the travis config for py35 altogether. |
|
Thank you for this work. To be honest I didn't expect it to be so much of an improvement. |
You and @leplatrem have been very kind to me and made my first experience with open source extremely welcoming. I'm very happy to have started here at Kinto 😀 |
|
Let's make a quick poll: https://twitter.com/Natim/status/1064904568272764931 |
I think you may need to edit your link |
|
I did indeed 💃 |
|
10 days later: |
|
Looks good! |
|
Could you please update your branch, we'll merge ;) |
|
Is there anything that still needs to be done from me? 👍 |
|
Nope it seems good to me 👍 |
|
Changelog is not properly dated on 12.0.0 |
|
It's still unreleased and it's marked as such, so I think it's OK, right? |
|
Yes it is the normal process, the date is fixed only when we release it. |
Fixes #1659
For when it's necessary to drop support for older Python Versions.
kinto/config/__init__.pykinto/schema_validation.pykinto/core/scripts.pykinto/core/openapi.pykinto/core/__init__.pykinto/core/utils.pykinto/core/cache/postgresql/__init__.pykinto/core/storage/memory.pykinto/core/storage/exceptions.pykinto/core/storage/postgresql/client.pykinto/core/storage/testing.pykinto/core/statsd.pykinto/core/initialization.pykinto/core/resource/model.pykinto/core/resource/schema.pykinto/core/permission/memory.pykinto/core/views/heartbeat.pykinto/core/views/errors.pykinto/core/views/batch.pykinto/core/testing.pykinto/plugins/quotas/scripts.pykinto/plugins/quotas/listener.pykinto/plugins/openid/__init__.pykinto/plugins/openid/views.pykinto/plugins/default_bucket/__init__.pykinto/plugins/history/listener.pykinto/authorization.pykinto/views/records.pykinto/core/authentication.pykinto/core/events.pykinto/core/storage/postgresql/__init__.pykinto/core/storage/postgresql/migrator.pykinto/core/errors.pykinto/core/resource/__init__.pykinto/core/resource/viewset.pykinto/core/permission/postgresql/__init__.pykinto/core/authorization.pykinto/plugins/accounts/scripts.pykinto/plugins/accounts/__init__.pykinto/plugins/accounts/views.pykinto/plugins/accounts/authentication.pykinto/views/permissions.pykinto/views/groups.pykinto/__main__.pyCleanup