Skip to content
This repository has been archived by the owner on Mar 9, 2019. It is now read-only.

DIRECTIVE_PATTERN matching too much #2

Open
ameboide opened this issue Apr 25, 2014 · 1 comment
Open

DIRECTIVE_PATTERN matching too much #2

ameboide opened this issue Apr 25, 2014 · 1 comment

Comments

@ameboide
Copy link

The regexp that matches directives is too generic, which results in actual lines of code being stripped. For example, it breaks the marionette framework by stripping the 3rd line in the stripDirectives task:

      hash[v.replace(pattern, function(r) {
        return ui[r.slice(4)];
      })] = hash[v];
@Fire-Dragon-DoL
Copy link

For the moment, I think a good idea is to use the file as a "manifest" (don't put code inside), it's a valid option right now.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants