Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: MLIBZ-2530 Handle OAuth errors in redirect uri responses after MIC login flow #197

Conversation

yuliya-guseva
Copy link
Contributor

Description

The goal of the task is to process error message from redirect_uri

Changes

In UserStore#onOAuthCallbackReceived fixed logic of redirect_uri processing

Tests

Instrumented

@codecov-io
Copy link

Codecov Report

Merging #197 into indev will increase coverage by 31.34%.
The diff coverage is 0%.

Impacted file tree graph

@@              Coverage Diff              @@
##              indev     #197       +/-   ##
=============================================
+ Coverage     34.39%   65.74%   +31.34%     
- Complexity      238      552      +314     
=============================================
  Files            42       42               
  Lines          3169     3170        +1     
  Branches        479      479               
=============================================
+ Hits           1090     2084      +994     
+ Misses         1950      930     -1020     
- Partials        129      156       +27
Impacted Files Coverage Δ Complexity Δ
.../main/java/com/kinvey/android/store/UserStore.java 66.55% <0%> (-0.22%) 31 <0> (ø)
...in/java/com/kinvey/android/AsyncClientRequest.java 63.63% <0%> (ø) 9% <0%> (-1%) ⬇️
...java/com/kinvey/android/AndroidMimeTypeFinder.java 1.81% <0%> (+1.81%) 1% <0%> (+1%) ⬆️
...d-lib/src/main/java/com/kinvey/android/Client.java 53.07% <0%> (+10.03%) 17% <0%> (+3%) ⬆️
.../main/java/com/kinvey/android/cache/ClassHash.java 63.69% <0%> (+27.38%) 118% <0%> (+64%) ⬆️
...ava/com/kinvey/android/cache/TableNameManager.java 95% <0%> (+30%) 8% <0%> (+3%) ⬆️
...vey/android/network/AsyncLinkedNetworkManager.java 32.5% <0%> (+32.5%) 2% <0%> (+2%) ⬆️
...va/com/kinvey/android/cache/RealmCacheManager.java 76.64% <0%> (+34.01%) 37% <0%> (+19%) ⬆️
...ain/java/com/kinvey/android/cache/QueryHelper.java 64.42% <0%> (+56.37%) 26% <0%> (+22%) ⬆️
.../main/java/com/kinvey/android/store/DataStore.java 84.78% <0%> (+69.13%) 40% <0%> (+36%) ⬆️
... and 7 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 91c0137...7841005. Read the comment docs.

Copy link
Contributor

@vinaygahlawat vinaygahlawat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add a unit test with a mock URI with error= in it to verify this logic?

@yuliya-guseva yuliya-guseva changed the title feat: MLIBZ-2518 Handle OAuth errors in redirect uri responses after MIC login flow feat: MLIBZ-2530 Handle OAuth errors in redirect uri responses after MIC login flow Oct 1, 2018
Copy link
Contributor

@vinaygahlawat vinaygahlawat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yuliya-guseva yuliya-guseva merged commit 68ad60c into indev Oct 3, 2018
@yuliya-guseva yuliya-guseva deleted the feature/MLIBZ-2518_Handle_OAuth_errors_in_redirect_uri_responses_after_MIC_login_flow branch October 3, 2018 15:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants