Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Regression] Tokens cannot be omitted via empty strings #106

Open
Kir-Antipov opened this issue Jan 20, 2024 Discussed in #103 · 0 comments
Open

[Regression] Tokens cannot be omitted via empty strings #106

Kir-Antipov opened this issue Jan 20, 2024 Discussed in #103 · 0 comments
Assignees
Labels
bug Something isn't working

Comments

@Kir-Antipov
Copy link
Owner

Discussed in #103

Originally posted by MattiDragon January 20, 2024
I'm using this action, wrapped in a custom workflow that does other things. I recently updated my version from v3.2 to v3.3.0 and something seems to have broken with the handling of missing tokens. One my projects isn't published on curseforge, so I don't provide a token or project it in its workflow. This used to work, but now I'm getting an error that the curseforge project doesn't exist. This shouldn't happen as no token is provided, unless mc-publish decided to pick up the unused CURSEFORGE_TOKEN actions secret without me giving it as input (the token is there because I sync my tokens to all mods that need any of them). I'm just confused as to where mc-publish is getting something it thinks is a curseforge token (it should ignore empty strings, right?)

@Kir-Antipov Kir-Antipov added the bug Something isn't working label Jan 20, 2024
@Kir-Antipov Kir-Antipov self-assigned this Jan 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant