Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

files-secondary is ignored without files-primary being present #47

Closed
ginsm opened this issue Jan 25, 2023 · 3 comments
Closed

files-secondary is ignored without files-primary being present #47

ginsm opened this issue Jan 25, 2023 · 3 comments
Labels
bug Something isn't working

Comments

@ginsm
Copy link

ginsm commented Jan 25, 2023

Howdy, how would you go about disabling files-secondary entirely? I only want it to upload the main file and nothing else.

I tried build/libs/!* but it seemed to ignore it (I'm guessing that's an invalid glob pattern?).

Thanks and awesome project! :)

@Kir-Antipov
Copy link
Owner

Hi!

build/libs/!* is a perfectly valid glob pattern, which means "look for nothing in build/libs". This is just an over-complicated way to say "choose nothing", i.e.

files-secondary: ""

Anyway, it should not be ignored. So, I took a look at your publish.yml and here's a problem - I thought, that it would be logical to assume, that a person, which redefines files-secondary, also redefines files-primary, so I can use it as a trigger to read these two properties at the same time. And this is not true for your case, since you only wanted to disable publishing of secondary files.

I'll fix it in the next update. As for now, you need to define these options yourself:

files-primary: build/libs/!(*-@(dev|sources|javadoc)).jar
files-secondary: ""

Sorry for the temporary inconvenience

@Kir-Antipov Kir-Antipov changed the title Disabling secondary file upload entirely files-secondary is ignored without files-primary being present Jan 25, 2023
@Kir-Antipov Kir-Antipov added the bug Something isn't working label Jan 25, 2023
@ginsm
Copy link
Author

ginsm commented Jan 26, 2023

Awesome, thanks :)

@Kir-Antipov
Copy link
Owner

The issue is no longer relevant for v3.3+.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants