Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Addition to 'Column-in-row modifier' functionality #1

Open
AstudilloMarillo opened this issue Jan 6, 2024 · 15 comments
Open

Addition to 'Column-in-row modifier' functionality #1

AstudilloMarillo opened this issue Jan 6, 2024 · 15 comments

Comments

@AstudilloMarillo
Copy link

What I hoped this would allow me to do is, when holding this modifier, swap the currently selected column with the column number that I press. So for example, if column 1 is selected, and you press the number 3 key, the items in column 1 and 3 would get swapped. Column 1 would still be selected. This way you could reorganize your hotbar quickly without opening the inventory.

Right now, nothing happens when you hold the 'Column-in-row modifier' key and press a numbers key, so I believe adding this wouldn't interfere with current functionality.

Any chance this could be added?

@Kir-Antipov
Copy link
Owner

That's strange. It's already programmed to shift the slots in this scenario. Which version are you using?

As a side note, are you interested specifically in slot swapping (e.g., 1 2 3 4 -> 1 4 3 2), or the currently expected behavior (e.g., 1 2 3 4 -> 3 4 1 2) will do for you to?

@AstudilloMarillo
Copy link
Author

I think there is a miscommunication here, I'm not saying the currently implemented column-in-row modifier functionality is broken, it works as intended, I'm asking for an additional functionality that shouldn't interfere with the current functionality (I think).

For my suggestion, I'm specifically looking to swap slots, or at least the items in them.

So for example: if currently, hotbar slot number 5 is selected, and you would press the modifier + the 1 key, the item in slot 5 and the item in slot 1 would be swapped. No other slots would be affected, and slot 5 would still be selected. There is no other mod right now that I've found that has this functionality, but I think it could be a really quick and convenient way to reorganize your hotbar without opening the inventory.

I hope this explanation is more clear, sorry for any confusion.
(I'm using the latest 1.1 for 1.20 btw for the sake of completion)

@Kir-Antipov
Copy link
Owner

I think there is a miscommunication here, I'm not saying the currently implemented column-in-row modifier functionality is broken, it works as intended

This contradicts your previous statement :D

Right now, nothing happens when you hold the 'Column-in-row modifier' key and press a numbers key

To be clear, this should "do something". If it doesn't - it's broken and I need to investigate it.

So for example: if currently, hotbar slot number 5 is selected, and you would press the modifier + the 1 key, the item in slot 5 and the item in slot 1 would be swapped. No other slots would be affected, and slot 5 would still be selected.

Don't worry, I understood your request from the original issue description. However, thank you for clarifying details such as "slot 5 would still be selected." I do like this idea a lot, it will be a great fit for this mod. Additionally, I can also implement row swapping and directional slot swapping. For instance, pressing the right arrow key would swap the currently selected slot with the one on the right while retaining its selection. This way, you can quickly reposition items in your hotbar without even needing to use number keys.

@AstudilloMarillo
Copy link
Author

To be clear, this should "do something". If it doesn't - it's broken and I need to investigate it.

Ah, I thought that was intended. What does work for me is holding the modifier and using the scroll wheel to shift the hotbar. Although that only seems to work 1 way for me (down), which I thought was curious.
What also works is holding the modifier and using the arrow keys.
I thought those things were all the intended behaviours and the modifier+numbers key wasn't supposed to do anything atm.

This contradicts your previous statement :D

I think the above clarifies that? Otherwise, sorry for being confusing :p

thank you for clarifying details such as "slot 5 would still be selected."

I got to say, I think this would feel most natural, but maybe it'll turn out selecting the "target" numbers key item slot would be better. Maybe make it an option? Or you could choose what feels most natural to you, once implemented.

Additionally, I can also implement row swapping and directional slot swapping.

That could be a nice addition as well!

Thanks for taking my idea into consideration, I'm very curious to see how this'll turn out :)!

@Kir-Antipov
Copy link
Owner

Although that only seems to work 1 way for me (down), which I thought was curious.

Wait, the scroll is broken too? Does this happen (or rather does not happen) only with column-related modifiers? Because I quickly tested the row-related stuff and it worked fine.

@AstudilloMarillo
Copy link
Author

AstudilloMarillo commented Jan 19, 2024

Wait, the scroll is broken too? Does this happen (or rather does not happen) only with column-related modifiers? Because I quickly tested the row-related stuff and it worked fine.

Oh wait, I'm so sorry, scroll is not broken (fortunately). I just realized it was just conflicting with another mod I was trying out called 'No Hotbar Looping' which locks scrolling 1 way when hotbar slot 1 or 9 is selected. It works totally fine when I disable that mod.

edit: that conflict makes total sense btw, no need to worry about it

@Kir-Antipov
Copy link
Owner

Got it! Thanks for the follow up :)

@AstudilloMarillo
Copy link
Author

Did you manage to make any progress on this by any chance? (No rush, just excited and curious)

@Kir-Antipov
Copy link
Owner

Sorry, not yet. Need to finalize a few projects before that :)

@AstudilloMarillo
Copy link
Author

No worries, take your time!
(you can delete these few messages if you want, btw, to reduce clutter)

@PukPukov
Copy link

PukPukov commented Jun 1, 2024

I think emulating vertical hotbar approach will fit better for immediate access than swapping approach.

If you do swapping, you need to store the full inventory dynamically in your brain for immediate access to full inventory and n required slots if you don't want to access ful inventory and for example want to only hotswap tools. Instead, if you do emulate vertical hotbar, you can cold memorize your standard inventory and dynamically remember only selected slot in vertical hotbar. So this will be much more useful for intense pvp, for example, if you need random access to much more than 9 items.

Technically this could be implemented by remapping access actions to swaps.

@AstudilloMarillo
Copy link
Author

This sounds like a completely different method to reach a completely different goal.

If you do swapping, you need to store the full inventory dynamically in your brain

The idea is to be able to swap already visible hotbar slots with each other, no need to "store" anything in your brain.

Vertical hotbar cycling is already possible with other mods.

@PukPukov
Copy link

PukPukov commented Jun 1, 2024

Then the name "Addition to 'Column-in-row modifier' functionality" is confusing. This functionality is about, as name says, columns, which are vertical.

@PukPukov
Copy link

PukPukov commented Jun 1, 2024

Oops, I mixed up column-in-row and row-in-column.

@Kir-Antipov
Copy link
Owner

I also need to work on the naming for these things :D

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants