Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CPS BuildProject.cs should log build result exception if any #3

Open
KirillOsenkov opened this issue May 13, 2017 · 0 comments
Open
Labels

Comments

@KirillOsenkov
Copy link
Owner

DevDiv 362186

In the code here:
http://index/?leftProject=Microsoft.VisualStudio.ProjectSystem&leftSymbol=gqgqt9etcoqs&rightProject=Microsoft.VisualStudio.ProjectSystem.Implementation&file=Build%5CBuildProject.cs&line=578

it is possible that result.Exception is not null (there was an exception during build).

CPS should check the result.Exception and if it's not null, log exception.ToString() to the errorTraceLogger.

The fact that this exception gets lost otherwise makes it super hard to debug design-time build failures. The log just says BUILD FAILED and that's it.

"Doesn't meet the bar"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant