Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nav bar doesn't work on mobile #106

Closed
KirstieJane opened this issue Oct 13, 2016 · 14 comments · Fixed by #110
Closed

Nav bar doesn't work on mobile #106

KirstieJane opened this issue Oct 13, 2016 · 14 comments · Fixed by #110

Comments

@KirstieJane
Copy link
Owner

So saaaad!

I can see the nav-bar but when I click on it it doesn't show me anything.

If anyone knows why please comment!

@Ryuno-Ki
Copy link

The JavaScript isn't loaded.

Open the developer tools of your web browser and look at the Network pane. For Firefox, it is explained on MDN.

@Ryuno-Ki
Copy link

I checked with Web IDE as well (you need to download an ISO and then hit the browser app on the left side to get access to Developer Tools there).
screenshot_stemmrolemodels320x533px

The image is too big. Related to #98?

@Ryuno-Ki
Copy link

Concerning WebIDE.

My battery runs dry in a few minutes.

@geminiimatt
Copy link

i am taking a look at this as well. more soon.

@amitkumarj441
Copy link
Contributor

@KirstieJane Did you import the jQuery before importing bootstrap, out of order it won't work!
For ex:
`<script src="https://ajax.googleapis.com/ajax/libs/jquery/2.1.3/jquery.min.js"></script>

<script src="https://maxcdn.bootstrapcdn.com/bootstrap/3.3.5/js/bootstrap.min.js"></script>`

@KirstieJane
Copy link
Owner Author

KirstieJane commented Oct 18, 2016

Hi @geminiimatt - thank you for taking this on - I'm going to assign you to this issue! [EDIT: wait - no I'm not because you aren't a contributor. Ok, you're virtually assigned 😉] Very likely @amitkumarj441 and @Ryuno-Ki's comments will be helpful!

@Ryuno-Ki - the fact that the image is too big is a different issue!! It needs to be fixed too. If you have time and feel like it you could open a new issue to describe the problem!

Thank you all for your help 😄

@amitkumarj441
Copy link
Contributor

Hey @KirstieJane ,

I hope you checked my comment on this issue, well I'll soon fix this issue by adding the navbar switching part in js file. Let me assign this issue, I'm going to fix this bug.

Cheers,
Amit Kumar Jaiswal

@Ryuno-Ki
Copy link

Hey, @KirstieJane,

sadly I'm overloaded with work at the moment. But I'm still watching this repo and chime in, whenever I can help.

@stain88
Copy link
Contributor

stain88 commented Oct 20, 2016

Hey @KirstieJane,

It looks like none of the pages source bootstrap js, and only the search_database page has jquery. I've added a cdn link to all the pages, and the dropdown now works, although the first couple of links sit next to the logo. Would it be worth having this as a navbar-brand class and moving it out of the collapse, so that it is always visible?

E I also did a bit of html-linting while in the files, there were a few instances of improperly closed tags, mis-matching tags

@Ryuno-Ki
Copy link

CDNs are fine. Until they got down (b/c of a DDoS, for example).

We should look after adding some decent styles in a <noscript> to keep the site usable.

@KirstieJane
Copy link
Owner Author

Thanks @stain88! I've merged your changes! And now the navbar works! Great!

BUT - I agree that it shouldn't have the logo on the inside of the collapse. Any pull requests on that front are very welcome 😄

@stain88
Copy link
Contributor

stain88 commented Oct 24, 2016

Cool, I'll work on that tomorrow

@KirstieJane
Copy link
Owner Author

@Ryuno-Ki I don't think DDoS happen often enough for a no script version to be of high priority. But if you or anyone else wanted to work on it then that's fine.

@stain88
Copy link
Contributor

stain88 commented Oct 24, 2016

Problem is, I was silently laughing at that too, but then that whole DynDNS DDOS happened and took down Twitter, Github, Reddit, and others, so I'll put it in locally with the nav bar changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants