Skip to content
This repository has been archived by the owner on Feb 9, 2023. It is now read-only.

IE11 - Object doesn't support property or method 'includes' #11

Closed
cleptric opened this issue Jan 4, 2019 · 7 comments
Closed

IE11 - Object doesn't support property or method 'includes' #11

cleptric opened this issue Jan 4, 2019 · 7 comments

Comments

@cleptric
Copy link

cleptric commented Jan 4, 2019

The transpiled vue-gallery-slideshow.js file contains a usage of includes, which isn't supported by IE11.
if (!style.ids.includes(id)) {...
Regarding to the .babelrc, it should not use this method.

@matkovsky
Copy link

matkovsky commented Jan 18, 2019

Also, there is an arrow function in the dist code, which breaks in IE11. 😭

image

https://github.com/KitchenStories/vue-gallery-slideshow/blob/master/dist/js/vue-gallery-slideshow.js#L198

@barnabas-szekeres
Copy link

Same issue here! :(

@normansander
Copy link
Contributor

:/ Thanks for report. There must be something wrong with the rollout and babel configuration. I didn't found a workaround yet but I will fix it.

@matkovsky
Copy link

I'd try to add "ie >= 10" to the targets in .babelrc, and see if it fixes the issue. :)

@iamqqv
Copy link

iamqqv commented Feb 12, 2019

@matkovsky your fix fixes that arrow function issue. thank you!

@normansander
Copy link
Contributor

normansander commented Feb 12, 2019

ok, I'll change this in the coming release. Thanks @matkovsky for this hint and @iamqqv for validation of this fix 👍 ❤️

@iamqqv
Copy link

iamqqv commented Feb 14, 2019

cool, thank you. any idea about this includes error? maybe this does also get fixed with the ie >= 10, not sure, tho!

@cleptric cleptric closed this as completed Apr 9, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants