Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Too many libraries specified in Makefile #377

Open
NicoHood opened this issue Feb 22, 2018 · 0 comments · May be fixed by #383
Open

Too many libraries specified in Makefile #377

NicoHood opened this issue Feb 22, 2018 · 0 comments · May be fixed by #383

Comments

@NicoHood
Copy link

NicoHood commented Feb 22, 2018

# Make sure you have Atlas installed. You can statically link Atlas if you
# would like to be able to move the library to a machine without Atlas.
ifneq ("$(ldconfig -p | grep lapack_atlas)","")
LDLIBS := -lm -ldl -lf77blas -lcblas -llapack_atlas -latlas
else
LDLIBS := -lm -ldl -lf77blas -lcblas -llapack -latlas
endif

# current
LDLIBS := -lm -ldl -lf77blas -lcblas -llapack -latlas
# required
LDLIBS := -lm -lcblas

The makefile specifies too many libraries which are not required. This becomes a problem if you do not have them all installed. (Assuming I understood correct:) If those all provide an atlas ABI implementation, those libs should get included different, but not like this.

I can imagine two fixes:

  1. Just remove the other libs (as suggested above)
  2. Add more ldconfig if/else checks and only load one library, not all

Since the extra line was only added for archlinux, it could be made smaller I guess (option1):
0a4a6b3

\cc @c4tz

@NicoHood NicoHood linked a pull request Feb 25, 2018 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant