New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Removed warnings found in Swift 4.1 #34
Conversation
Codecov Report
@@ Coverage Diff @@
## master #34 +/- ##
=========================================
Coverage ? 76.72%
=========================================
Files ? 10
Lines ? 954
Branches ? 0
=========================================
Hits ? 732
Misses ? 222
Partials ? 0
Continue to review full report at Codecov.
|
You checked in the Xcode project.... Please remove it and add |
Sources/Cryptor/StreamCryptor.swift
Outdated
self.context.deallocate() | ||
#else | ||
self.context.deallocate(capacity: 1) | ||
self.haveContext = false |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think this line should be inside the #if
block?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hang on, I'm an idiot. I didn't realise this project has an Xcode project checked in already :(
In that case, I don't think we should touch it in this PR. @KyeMaloy97 can you remove the change to .gitignore
and Cryptor.xcodeproj
.
Just change .swift-version
, Sources
and .travis.yml
in this PR.
Sorry.
91dae9b
to
bb5fa2b
Compare
This PR looks fine to me. Will merge it. An' yes, it has an Xcode project. This is because there are variations on the build for different platforms that have been requested by users. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks fine as is with the Xcode project.
There are a low level API changes in Swift 4.1 which were giving warnings in other projects that depended on this repo, such as Kitura Websocket.
This PR just adds some conditional checks to use the relevant API depending on the Swift version.
Ran the test suite locally and built locally too on Swift 3.1.1, 4.0.3 and 4.1. I have added Travis builds for these Swift versions too.