Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Repair all links after transition away from IBM #80

Merged
merged 1 commit into from Oct 27, 2020
Merged

Repair all links after transition away from IBM #80

merged 1 commit into from Oct 27, 2020

Conversation

ghost
Copy link

@ghost ghost commented Oct 27, 2020

Description

After all of the README links relating to IBM have been removed. We may need to remove the CLA form from the pull request template as well, thoughts?

Motivation and Context

Fixes broken links for proper documentation

How Has This Been Tested?

No testing required

Checklist:

Is this CLA form necessary anymore? The email address just bounces now anyways

  • I have submitted a CLA form
  • If applicable, I have updated the documentation accordingly.
  • If applicable, I have added tests to cover my changes.

@CLAassistant
Copy link

CLAassistant commented Oct 27, 2020

CLA assistant check
All committers have signed the CLA.

@sonarcloud
Copy link

sonarcloud bot commented Oct 27, 2020

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@ghost
Copy link
Author

ghost commented Oct 27, 2020

The CLA bot appears to be broken too, clicking the above link does nothing and in the console:

[Debug] $HUB (3) (angular.min.js, line 125)
{obj: "users", fun: "getAuthenticated", arg: {}}
ResultSet {loaded: true, loading: false, error: "Authentication required", affix: null, value: null, …}
"Authentication required"

EDIT
This did eventually load, but still may be unnecessary now that IBM is not maintaining

@dannys42
Copy link
Contributor

Thanks for the update! The CLA tool should be working and should not be showing IBM-specific language. Let me know if you have any other issues with it.

@dannys42 dannys42 merged commit cdf6aa8 into Kitura:master Oct 27, 2020
@alex-taffe
Copy link

@dannys42 the PR template has some weird PDF that it wants you to fill out and mail/email to an IBM address. Should that be removed and just let the bot do its thing?

@dannys42
Copy link
Contributor

dannys42 commented Oct 30, 2020

@alex-taffe Oh I see. Yes, thanks for pointing that out. I'll update the PR template.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants