Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Package name is "Credentials" makes scoping a problem #36

Open
crspybits opened this issue Nov 30, 2016 · 2 comments
Open

Package name is "Credentials" makes scoping a problem #36

crspybits opened this issue Nov 30, 2016 · 2 comments

Comments

@crspybits
Copy link
Contributor

Thanks guys for this work-- I'm starting to use it in a project. I'd considered forking, as I was starting to use Perfect, but decided just to use Kitura and not fork. Why make more work? Anyways, a small comment here. Because Credentials is both the package name and a class name, it doesn't seem possible to use Credentials (package name) for scoping. i.e., this is a syntax error:

let credentials = Credentials.Credentials()

Perhaps a different package name?

All going well, I'll be adding additional auth plugin(s). E.g., for Dropbox.

@krzyzanowskim
Copy link

I'd say a different package name is the best option due to compiler limitation.

@tunniclm
Copy link
Collaborator

tunniclm commented Feb 7, 2018

This is definitely causing problems, and I think we should look at fixing this by changing the package name and/or the the type name for the middleware.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants