Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

testSimpleHTTPClient is flaky and buggy #21

Closed
pushkarnk opened this issue May 28, 2018 · 2 comments
Closed

testSimpleHTTPClient is flaky and buggy #21

pushkarnk opened this issue May 28, 2018 · 2 comments
Labels
good first issue Good for newcomers

Comments

@pushkarnk
Copy link
Contributor

pushkarnk commented May 28, 2018 •
edited
Loading

testSimpleHTTPClient does a GET to http://www.ibm.com and asserts that the HTTP status returned is OK. In reality, we sometimes seem to be getting a movedTemporarily, the reason for which is beyond the scope of this project. I have #20 raised for this.

There's another problem in the test case. The test makes the request but does not wait for expectations to be fulfilled. In the case of failure, some other test appears to have failed. This needs to be fixed, but it may increase the test times. I propose we watch the behaviour with #20 and take a call later, accordingly.
@pushkarnk pushkarnk added the good first issue Good for newcomers label Jun 28, 2018
@pushkarnk
Copy link
Contributor Author

pushkarnk commented Aug 28, 2018 •
edited
Loading

This hasn't failed for a long time now. Closing the issue for now. Will reopen if the failure resurfaces.

@pushkarnk
Copy link
Contributor Author

Oh, btw, this is a pull request to use an expectation in this test case
#80

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@pushkarnk