Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enforce NPM >= 5.2 #9

Closed
ianpartridge opened this issue Nov 8, 2017 · 2 comments
Closed

Enforce NPM >= 5.2 #9

ianpartridge opened this issue Nov 8, 2017 · 2 comments

Comments

@ianpartridge
Copy link
Contributor

ianpartridge commented Nov 8, 2017

Once #5 lands and we are using npx, we should specify that we require NPM >= 5.2 in the package.json:

{ "engines" : { "npm" : ">=5.2.0" } }

Documentation.

@ianpartridge
Copy link
Contributor Author

ianpartridge commented Nov 9, 2017

Researching this further, it seems that specifying a version of NPM in "engines" is for which version of NPM can install a package, not which version of NPM a package requires at runtime.

We are probably better off using something like https://www.npmjs.com/package/check-node-version or just trying to run npx and giving a good error message if that fails.

@ianpartridge
Copy link
Contributor Author

In c96c2ec I took the approach of "suck it and see". Try and run npx, and if that fails print an error message advising NPM >= 5.2.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant