Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move away from the concrete mesh types; instead use functions. #125

Open
vibraphone opened this issue Aug 26, 2014 · 0 comments
Open

Move away from the concrete mesh types; instead use functions. #125

vibraphone opened this issue Aug 26, 2014 · 0 comments
Milestone

Comments

@vibraphone
Copy link
Member

Since MeshIOType now holds (or will soon) a pair of strings instead of integer IDs, we should eliminate remus::meshtypes::MeshTypeBase in favor of just using strings. The canonical mesh type names (e.g., "Mesh3D", "PiecewiseLinearComplex") would be exposed as functions:

namespace remus {
  namespace meshtypes {
    /// 3-dimensional mesh objects in MOAB format
    std::string Mesh3D() { return "Mesh3D"; }
    /// A piecewise linear complex
    std::string PiecewiseLinearComplex() { return "PiecewiseLinearComplex"; }
    // ...
  }
}

to make it easier to ensure that strings match throughout applications. Then the MeshRegistrar class would be invoked inside the MeshIOType constructor to maintain a list of all mesh types in use locally.

@robertmaynard robertmaynard added this to the v0.5 milestone Aug 26, 2014
@robertmaynard robertmaynard modified the milestones: v0.5, v0.6 Feb 27, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants